Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: associate ghost user with posts on user deletion. #3293

Merged
merged 5 commits into from
Feb 15, 2023
Merged

perf: associate ghost user with posts on user deletion. #3293

merged 5 commits into from
Feb 15, 2023

Conversation

JackyLiang522
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

文章发布用户被删除后，设置这篇文章的发布人为Ghost

Which issue(s) this PR fixes:

Fixes #3265

NONE

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Feb 12, 2023
@JackyLiang522 JackyLiang522 requested review from guqing and removed request for lan-yonghui February 14, 2023 02:06
@ruibaby ruibaby changed the title fix issue 3265 perf: associate ghost user with posts on user deletion. Feb 14, 2023
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2023
guqing
guqing reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

ruibaby
ruibaby reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@TGSMLM
Copy link

TGSMLM commented Feb 15, 2023 via email

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit e485ace into halo-dev:main Feb 15, 2023
@ruibaby
Copy link
Member

ruibaby commented Feb 15, 2023

/cherry-pick release-2.2

@halo-dev-bot halo-dev-bot mentioned this pull request Feb 15, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #3309

In response to this:

/cherry-pick release-2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.3.x, 2.3.0 Feb 15, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 15, 2023
@halo-dev-bot
[release-2.2] perf: associate ghost user with posts on user deletion. (…
f0e19ca 
…#3309)

This is an automated cherry-pick of #3293

/assign ruibaby

```release-note
NONE
```
@JohnNiang JohnNiang mentioned this pull request Feb 15, 2023
Closed
@JackyLiang522 JackyLiang522 deleted the issue3265 branch February 23, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby approved these changes

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

文章发布用户被删除后，文章解析报错
6 participants
@JackyLiang522 @TGSMLM @ruibaby @halo-dev-bot @JohnNiang @guqing